Fix crash: Editor is thin — no threads, no scan ownership, just reads Processor state

Source/PluginBridgeEditor.cpp

@@ -5,48 +5,35 @@ PluginBridgeEditor::PluginBridgeEditor(PluginBridgeProcessor& p)
 {
     setSize(360, 220);
 
-    // Register formats for scanning
-    #if JUCE_PLUGINHOST_VST3
-    scanFormatManager.addFormat(new juce::VST3PluginFormat());
-    #endif
-    #if JUCE_PLUGINHOST_AU
-    scanFormatManager.addFormat(new juce::AudioUnitPluginFormat());
-    #endif
-
-    // Title
     titleLabel.setText("PluginBridge", juce::dontSendNotification);
     titleLabel.setFont(juce::FontOptions(22.0f));
     titleLabel.setJustificationType(juce::Justification::centred);
     titleLabel.setColour(juce::Label::textColourId, juce::Colours::white);
     addAndMakeVisible(titleLabel);
 
-    // MCP status
     statusLabel.setText("MCP: starting...", juce::dontSendNotification);
     statusLabel.setFont(juce::FontOptions(12.0f));
     statusLabel.setJustificationType(juce::Justification::centred);
     addAndMakeVisible(statusLabel);
 
-    // Port
     portLabel.setText("", juce::dontSendNotification);
     portLabel.setFont(juce::FontOptions(10.0f));
     portLabel.setJustificationType(juce::Justification::centred);
     portLabel.setColour(juce::Label::textColourId, juce::Colour(0xff888888));
     addAndMakeVisible(portLabel);
 
-    // Plugin name display
     pluginLabel.setText("No plugin loaded", juce::dontSendNotification);
     pluginLabel.setFont(juce::FontOptions(13.0f));
     pluginLabel.setJustificationType(juce::Justification::centred);
     pluginLabel.setColour(juce::Label::textColourId, juce::Colour(0xffaaaaaa));
     addAndMakeVisible(pluginLabel);
 
-    // Plugin selector button
-    pluginButton.onClick = [this]() { scanAndShowMenu(); };
+    pluginButton.onClick = [this]() { pluginButtonClicked(); };
     pluginButton.setColour(juce::TextButton::buttonColourId, juce::Colour(0xff2d2d44));
     pluginButton.setColour(juce::TextButton::textColourOffId, juce::Colours::white);
     addAndMakeVisible(pluginButton);
 
-    startTimerHz(2);
+    startTimerHz(4);
 }
 
 PluginBridgeEditor::~PluginBridgeEditor()
@@ -76,6 +63,7 @@ void PluginBridgeEditor::resized()
 
 void PluginBridgeEditor::timerCallback()
 {
+    // MCP status
     if (processorRef.isMcpServerRunning())
     {
         statusLabel.setText("MCP: running", juce::dontSendNotification);
@@ -90,6 +78,7 @@ void PluginBridgeEditor::timerCallback()
         portLabel.setText("", juce::dontSendNotification);
     }
 
+    // Plugin status
     auto& mgr = processorRef.getHostedPluginManager();
     if (mgr.isLoaded())
     {
@@ -102,74 +91,52 @@ void PluginBridgeEditor::timerCallback()
     {
         pluginLabel.setText("No plugin loaded", juce::dontSendNotification);
         pluginLabel.setColour(juce::Label::textColourId, juce::Colour(0xff888888));
-        pluginButton.setButtonText("Select Plugin...");
+        if (!processorRef.isScanning())
+            pluginButton.setButtonText("Select Plugin...");
+    }
+
+    // Update button during scan
+    if (processorRef.isScanning())
+    {
+        pluginButton.setButtonText("Scanning...");
+        pluginButton.setEnabled(false);
+    }
+    else
+    {
+        pluginButton.setEnabled(true);
     }
 }
 
-void PluginBridgeEditor::scanAndShowMenu()
+void PluginBridgeEditor::pluginButtonClicked()
 {
-    // If already scanned, just show menu immediately
-    if (scanComplete)
+    if (processorRef.isScanComplete())
     {
+        // Scan done — show menu immediately
         showPluginMenu();
-        return;
     }
-
-    // If currently scanning, ignore click
-    if (scanning)
-        return;
-
-    // Scan in background thread
-    scanning = true;
-    pluginButton.setButtonText("Scanning...");
-    pluginButton.setEnabled(false);
-
-    auto* thisPtr = this;
-    std::thread([thisPtr]()
+    else if (!processorRef.isScanning())
     {
-        for (int i = 0; i < thisPtr->scanFormatManager.getNumFormats(); ++i)
-        {
-            auto* format = thisPtr->scanFormatManager.getFormat(i);
-            auto searchPaths = format->getDefaultLocationsToSearch();
-
-            juce::PluginDirectoryScanner scanner(
-                thisPtr->knownPlugins,
-                *format,
-                searchPaths,
-                true,
-                juce::File()
-            );
-
-            juce::String pluginName;
-            while (scanner.scanNextFile(false, pluginName)) {}
-        }
-
-        // Back to message thread to show menu
-        juce::MessageManager::callAsync([thisPtr]()
-        {
-            thisPtr->scanning = false;
-            thisPtr->scanComplete = true;
-            thisPtr->pluginButton.setEnabled(true);
-            thisPtr->pluginButton.setButtonText("Select Plugin...");
-            thisPtr->showPluginMenu();
-        });
-    }).detach();
+        // Start scan (owned by Processor — safe even if editor closes)
+        processorRef.startPluginScan();
+        // Timer will update button text to "Scanning..." and show menu when done
+    }
 }
 
 void PluginBridgeEditor::showPluginMenu()
 {
-    juce::PopupMenu menu;
-    auto types = knownPlugins.getTypes();
+    const auto& types = processorRef.getScannedPlugins();
 
     if (types.isEmpty())
     {
+        juce::PopupMenu menu;
         menu.addItem(-1, "(No plugins found)", false);
         menu.showMenuAsync(juce::PopupMenu::Options().withTargetComponent(&pluginButton),
             [](int) {});
         return;
     }
 
-    // Group by manufacturer as submenus
+    // Group by manufacturer
+    juce::PopupMenu menu;
     juce::StringArray manufacturers;
     for (const auto& desc : types)
     {
@@ -199,7 +166,7 @@ void PluginBridgeEditor::showPluginMenu()
 
 void PluginBridgeEditor::loadPluginByIndex(int index)
 {
-    auto types = knownPlugins.getTypes();
+    const auto& types = processorRef.getScannedPlugins();
     if (index >= 0 && index < types.size())
     {
         const auto& desc = types[index];