Fix crash on load: Add try/catch around findAllTypesForFile + createPluginInstance, use async path

Source/HostedPluginManager.cpp

@@ -2,7 +2,6 @@
 
 HostedPluginManager::HostedPluginManager()
 {
-    // Register VST3 and AU formats explicitly (addDefaultFormats() removed in JUCE 8)
     #if JUCE_PLUGINHOST_VST3
     formatManager.addFormat(new juce::VST3PluginFormat());
     #endif
@@ -19,7 +18,6 @@ HostedPluginManager::~HostedPluginManager()
 void HostedPluginManager::loadPlugin(const juce::File& pluginFile,
                                       double sampleRate, int blockSize)
 {
-    // Unload existing plugin first
     unloadPlugin();
 
     currentSampleRate = sampleRate;
@@ -28,57 +26,66 @@ void HostedPluginManager::loadPlugin(const juce::File& pluginFile,
     juce::String errorMessage;
     juce::OwnedArray<juce::PluginDescription> typesFound;
 
-    // Scan the file to find plugin descriptions
-    for (int i = 0; i < formatManager.getNumFormats(); ++i)
+    // Wrap in try/catch — some plugins throw or show dialogs that cause exceptions
+    try
     {
-        auto* format = formatManager.getFormat(i);
-        format->findAllTypesForFile(typesFound, pluginFile.getFullPathName());
-        if (typesFound.size() > 0)
-            break;
+        for (int i = 0; i < formatManager.getNumFormats(); ++i)
+        {
+            auto* format = formatManager.getFormat(i);
+            format->findAllTypesForFile(typesFound, pluginFile.getFullPathName());
+            if (typesFound.size() > 0)
+                break;
+        }
     }
-
-    if (typesFound.isEmpty())
+    catch (...)
     {
-        DBG("PluginBridge: No plugin found in file: " + pluginFile.getFullPathName());
+        DBG("PluginBridge: Exception during plugin scan for: " + pluginFile.getFullPathName());
         return;
     }
 
-    // Use the first plugin description found
-    auto& desc = *typesFound[0];
-
-    // Create plugin instance (synchronous — safe here since we're on message thread)
-    auto instance = formatManager.createPluginInstance(
-        desc, sampleRate, blockSize, errorMessage);
-
-    if (instance == nullptr)
+    if (typesFound.isEmpty())
     {
-        DBG("PluginBridge: Failed to create plugin: " + errorMessage);
+        DBG("PluginBridge: No plugin found in file: " + pluginFile.getFullPathName());
         return;
     }
 
-    // Enable all buses before use
-    instance->enableAllBuses();
-
-    // Match bus layout: stereo in/out
-    auto layout = juce::AudioProcessor::BusesLayout();
-    layout.inputBuses.add(juce::AudioChannelSet::stereo());
-    layout.outputBuses.add(juce::AudioChannelSet::stereo());
-
-    if (instance->checkBusesLayoutSupported(layout))
-        instance->setBusesLayout(layout);
-
-    // Prepare for playback
-    instance->prepareToPlay(sampleRate, blockSize);
+    auto desc = *typesFound[0];
 
-    // Store
-    {
-        const juce::ScopedLock sl(pluginLock);
-        hostedPlugin = std::move(instance);
-        loadedPluginPath = pluginFile.getFullPathName();
-    }
-
-    DBG("PluginBridge: Loaded plugin: " + getPluginName()
-        + " (" + juce::String(getParameterCount()) + " params)");
+    // Use async creation — safer for AU plugins and plugins that need message thread
+    formatManager.createPluginInstanceAsync(desc, sampleRate, blockSize,
+        [this, pluginFile](std::unique_ptr<juce::AudioPluginInstance> instance,
+                           const juce::String& error)
+        {
+            if (instance == nullptr)
+            {
+                DBG("PluginBridge: Failed to create plugin: " + error);
+                return;
+            }
+
+            // Enable all buses
+            instance->enableAllBuses();
+
+            // Match bus layout: stereo in/out
+            auto layout = juce::AudioProcessor::BusesLayout();
+            layout.inputBuses.add(juce::AudioChannelSet::stereo());
+            layout.outputBuses.add(juce::AudioChannelSet::stereo());
+
+            if (instance->checkBusesLayoutSupported(layout))
+                instance->setBusesLayout(layout);
+
+            // Prepare for playback
+            instance->prepareToPlay(currentSampleRate, currentBlockSize);
+
+            // Store
+            {
+                const juce::ScopedLock sl(pluginLock);
+                hostedPlugin = std::move(instance);
+                loadedPluginPath = pluginFile.getFullPathName();
+            }
+
+            DBG("PluginBridge: Loaded plugin: " + getPluginName()
+                + " (" + juce::String(getParameterCount()) + " params)");
+        });
 }
 
 void HostedPluginManager::unloadPlugin()
@@ -160,7 +167,6 @@ std::vector<HostedPluginManager::ParamInfo> HostedPluginManager::searchParams(
             info.displayText = param->getText(param->getValue(), 64);
             info.automatable = param->isAutomatable();
 
-            // Try to get stable ID from HostedParameter
             if (auto* hosted = dynamic_cast<juce::AudioPluginInstance::HostedParameter*>(param))
                 info.id = hosted->getParameterID();
             else
@@ -169,7 +175,6 @@ std::vector<HostedPluginManager::ParamInfo> HostedPluginManager::searchParams(
             results.push_back(info);
         }
 
-        // Cap results to avoid token bloat
         if (results.size() >= 20)
             break;
     }