Fix crash: Editor shows instant file-based popup menu — zero binary loading until select

Source/PluginBridgeEditor.cpp

@@ -28,7 +28,7 @@ PluginBridgeEditor::PluginBridgeEditor(PluginBridgeProcessor& p)
     pluginLabel.setColour(juce::Label::textColourId, juce::Colour(0xffaaaaaa));
     addAndMakeVisible(pluginLabel);
 
-    pluginButton.onClick = [this]() { pluginButtonClicked(); };
+    pluginButton.onClick = [this]() { showPluginMenu(); };
     pluginButton.setColour(juce::TextButton::buttonColourId, juce::Colour(0xff2d2d44));
     pluginButton.setColour(juce::TextButton::textColourOffId, juce::Colours::white);
     addAndMakeVisible(pluginButton);
@@ -63,7 +63,6 @@ void PluginBridgeEditor::resized()
 
 void PluginBridgeEditor::timerCallback()
 {
-    // MCP status
     if (processorRef.isMcpServerRunning())
     {
         statusLabel.setText("MCP: running", juce::dontSendNotification);
@@ -78,7 +77,6 @@ void PluginBridgeEditor::timerCallback()
         portLabel.setText("", juce::dontSendNotification);
     }
 
-    // Plugin status
     auto& mgr = processorRef.getHostedPluginManager();
     if (mgr.isLoaded())
     {
@@ -91,86 +89,53 @@ void PluginBridgeEditor::timerCallback()
     {
         pluginLabel.setText("No plugin loaded", juce::dontSendNotification);
         pluginLabel.setColour(juce::Label::textColourId, juce::Colour(0xff888888));
-        if (!processorRef.isScanning())
-            pluginButton.setButtonText("Select Plugin...");
-    }
-
-    // Update button during scan
-    if (processorRef.isScanning())
-    {
-        pluginButton.setButtonText("Scanning...");
-        pluginButton.setEnabled(false);
-    }
-    else
-    {
-        pluginButton.setEnabled(true);
-    }
-}
-
-void PluginBridgeEditor::pluginButtonClicked()
-{
-    if (processorRef.isScanComplete())
-    {
-        // Scan done — show menu immediately
-        showPluginMenu();
-    }
-    else if (!processorRef.isScanning())
-    {
-        // Start scan (owned by Processor — safe even if editor closes)
-        processorRef.startPluginScan();
-        // Timer will update button text to "Scanning..." and show menu when done
+        pluginButton.setButtonText("Select Plugin...");
     }
 }
 
 void PluginBridgeEditor::showPluginMenu()
 {
-    const auto& types = processorRef.getScannedPlugins();
+    auto files = processorRef.getInstalledPluginFiles();
 
-    if (types.isEmpty())
+    juce::PopupMenu menu;
+
+    if (files.isEmpty())
     {
-        juce::PopupMenu menu;
         menu.addItem(-1, "(No plugins found)", false);
         menu.showMenuAsync(juce::PopupMenu::Options().withTargetComponent(&pluginButton),
             [](int) {});
         return;
     }
 
-    // Group by manufacturer
-    juce::PopupMenu menu;
-    juce::StringArray manufacturers;
-    for (const auto& desc : types)
-    {
-        if (!manufacturers.contains(desc.manufacturerName))
-            manufacturers.add(desc.manufacturerName);
-    }
-    manufacturers.sort(true);
+    // Group: VST3 submenu and AU submenu
+    juce::PopupMenu vst3Menu;
+    juce::PopupMenu auMenu;
+    int itemId = 1;
 
-    for (const auto& mfr : manufacturers)
+    for (int i = 0; i < files.size(); ++i)
     {
-        juce::PopupMenu subMenu;
-        for (int i = 0; i < types.size(); ++i)
-        {
-            if (types[i].manufacturerName == mfr)
-                subMenu.addItem(i + 1, types[i].name + "  [" + types[i].pluginFormatName + "]");
-        }
-        menu.addSubMenu(mfr, subMenu);
+        auto& file = files[i];
+        auto name = file.getFileNameWithoutExtension();
+
+        if (file.getFileExtension() == ".vst3")
+            vst3Menu.addItem(itemId, name);
+        else
+            auMenu.addItem(itemId, name);
+
+        itemId++;
     }
 
+    if (vst3Menu.getNumItems() > 0)
+        menu.addSubMenu("VST3", vst3Menu);
+    if (auMenu.getNumItems() > 0)
+        menu.addSubMenu("Audio Units", auMenu);
+
     menu.showMenuAsync(juce::PopupMenu::Options().withTargetComponent(&pluginButton),
-        [this](int result)
+        [this, files](int result)
         {
-            if (result > 0)
-                loadPluginByIndex(result - 1);
+            if (result > 0 && result <= files.size())
+            {
+                processorRef.loadPluginFromFile(files[result - 1]);
+            }
         });
 }
-
-void PluginBridgeEditor::loadPluginByIndex(int index)
-{
-    const auto& types = processorRef.getScannedPlugins();
-    if (index >= 0 && index < types.size())
-    {
-        const auto& desc = types[index];
-        juce::File pluginFile(desc.fileOrIdentifier);
-        processorRef.loadPluginFromFile(pluginFile);
-    }
-}